-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer image version typescript-node:20
#848
Conversation
|
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
typescript-node:18
Co-authored-by: Rez <[email protected]>
typescript-node:18
typescript-node:20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary
Node 18 needed for Storybook 8 to be run. Current node version is 16, therefore the image version for the container is upped to 18. I just wanted to be able to run
npm run start
right away after Codespaces loads.List of notable changes:
typescript-node:16
totypescript-node:20
What should reviewers focus on?
node -v
is indeed 20Steps to test:
node -v
v20.x.x
P.S. Tested it myself works.
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshots
label to the PR)Reviewer checklist:
Screenshots: