Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer image version typescript-node:20 #848

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

stamat
Copy link
Contributor

@stamat stamat commented Dec 2, 2024

Summary

Node 18 needed for Storybook 8 to be run. Current node version is 16, therefore the image version for the container is upped to 18. I just wanted to be able to run npm run start right away after Codespaces loads.

List of notable changes:

  • updated dev container image version from typescript-node:16 to typescript-node:20

What should reviewers focus on?

  • Verify that the node -v is indeed 20

Steps to test:

  1. Create a new codespace
  2. Run node -v
  3. Should say v20.x.x

P.S. Tested it myself works.

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 87b843a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stamat stamat requested a review from rezrah December 2, 2024 20:09
@stamat stamat changed the title update devcontainer image version typescript-node:18 Update devcontainer image version typescript-node:18 Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🟢 No design token changes found

@stamat stamat self-assigned this Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@stamat stamat changed the title Update devcontainer image version typescript-node:18 Update devcontainer image version typescript-node:18 Dec 2, 2024
@stamat stamat marked this pull request as ready for review December 3, 2024 11:07
@stamat stamat changed the title Update devcontainer image version typescript-node:18 Update devcontainer image version typescript-node:20 Dec 3, 2024
@stamat stamat requested a review from rezrah December 3, 2024 11:08
Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stamat stamat merged commit c008e13 into main Dec 3, 2024
18 checks passed
@stamat stamat deleted the stamat/dev-container-node-update branch December 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants