Add escape key handlers to open accordions and its inner content #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #519
List of notable changes:
esc
key press handler to open accordions titles, which both closes them and returns focusesc
key press handler to accordion content elements, which both closes the accordion and returns focus to the nearest toggle ancestor.What should reviewers focus on?
Steps to test:
Supporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots:
Escape key press event on accordion summaries:
Kapture.2024-01-23.at.13.43.44.mp4
Escape key press events on internal links on open accordions:
Kapture.2024-01-23.at.13.45.19.mp4