Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dictionary values scalar and vector for data name keys in Micro Manager config files #609

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Remove the dictionary values scalar and vector for data name keys in Micro Manager config files #609

wants to merge 3 commits into from
+7 −6

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jan 22, 2025 •
edited
Loading

Removing the scalar and vector values to data name keys in the Micro Manager config files as they are no longer necessary since precice/micro-manager#142

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Jan 22, 2025
@IshaanDesai IshaanDesai requested a review from uekerman January 22, 2025 10:03
uekerman
uekerman approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have not tested it.

@MakisH Should we document the version dependency somewhere? (We now require the newest develop branch of the Micro Manager)

changelog-entries/609.md Outdated Show resolved Hide resolved
@IshaanDesai @uekerman
Use past tense in changelog entry
d890f10 
Co-authored-by: Benjamin Uekermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uekerman uekerman uekerman approved these changes

Assignees

@IshaanDesai IshaanDesai

Labels
breaking change compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IshaanDesai @uekerman