Currency Opence Conversion: Updated build script for pillow. #5507
Conversation
| @@ -2,22 +2,19 @@ | |||
| "maintainer": "Harithanagothu2", | |||
| "package_name": "pillow", | |||
| "github_url": "https://github.com/python-pillow/Pillow", | |||
| "version": "10.0.1", | |||
| "version": "11.0.0", | |||
There was a problem hiding this comment.
why is script for pillow 11.1.0 not connected in build_info?
There was a problem hiding this comment.
As per discussion with @Harithanagothu2 .. it is understood that the build system picks up all versions in 11.* series for build
Based on this approving the PR
| "11.0.0": { | ||
| "build_script": "pillow_v11.0.0_ubi_9.3.sh" | ||
| "10.*": { | ||
| "build_script": "pillow_v10.0.1_ubi_9.3.sh" |
There was a problem hiding this comment.
build script version should be 11.1.0 in script name
There was a problem hiding this comment.
pillow_v11.0.0_ubi_9.3.sh script will work for 11.1.0 also.
There was a problem hiding this comment.
How you seem to be using version 11.0.0
Which version is ur script targetiing v11.0.0 or v11.1.0?
There was a problem hiding this comment.
@Harithanagothu2 : plz mention your explanation of hardcoding script name with specific version .. here
| "11.0.0": { | ||
| "build_script": "pillow_v11.0.0_ubi_9.3.sh" | ||
| "10.*": { | ||
| "build_script": "pillow_v10.0.1_ubi_9.3.sh" |
There was a problem hiding this comment.
@Harithanagothu2 : plz mention your explanation of hardcoding script name with specific version .. here
| @@ -2,22 +2,19 @@ | |||
| "maintainer": "Harithanagothu2", | |||
| "package_name": "pillow", | |||
| "github_url": "https://github.com/python-pillow/Pillow", | |||
| "version": "10.0.1", | |||
| "version": "11.0.0", | |||
There was a problem hiding this comment.
why is script for pillow 11.1.0 not connected in build_info?
| @@ -2,22 +2,19 @@ | |||
| "maintainer": "Harithanagothu2", | |||
| "package_name": "pillow", | |||
| "github_url": "https://github.com/python-pillow/Pillow", | |||
| "version": "10.0.1", | |||
| "version": "11.0.0", | |||
There was a problem hiding this comment.
As per discussion with @Harithanagothu2 .. it is understood that the build system picks up all versions in 11.* series for build
Based on this approving the PR
Checklist
set -eoption enabled and observe success ?