Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency: Created build script and build_info.json for import-tracker #5375

Open
wants to merge 3 commits into
base: python-ecosystem
Choose a base branch
from
Open

Currency: Created build script and build_info.json for import-tracker #5375

wants to merge 3 commits into from

Conversation

vivek8123
Copy link

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

shubham-dayma-ibm
shubham-dayma-ibm requested changes Feb 4, 2025
View reviewed changes
i/import-tracker/build_info.json Outdated
"validate_build_script": true,
"wheel_build" : true,
"use_non_root_user": false,
"*.*.*": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use * instead *.*.*

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

i/import-tracker/import_tracker_ubi_9.3.sh
PACKAGE_NAME=import-tracker
PACKAGE_VERSION=${1:-3.2.1}
PACKAGE_URL=https://github.com/IBM/import-tracker.git

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PACKAGE_DIR variable

@vivek8123 vivek8123 changed the title Created build script and build_info.json for import-tracker Currency: Created build script and build_info.json for import-tracker Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-dayma-ibm shubham-dayma-ibm shubham-dayma-ibm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivek8123 @shubham-dayma-ibm