Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODH: Added build-script, build info and license for vllm #5374

Open
wants to merge 1 commit into
base: odh-pe-integration
Choose a base branch
from
Open

ODH: Added build-script, build info and license for vllm #5374

wants to merge 1 commit into from

Conversation

Shafi-Hussain
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

@Shafi-Hussain Shafi-Hussain marked this pull request as ready for review January 30, 2025 10:00
npanpaliya
npanpaliya reviewed Jan 30, 2025
View reviewed changes
v/vllm/vllm_ubi_9.3.sh
PACKAGE_NAME=vllm
PACKAGE_URL=https://github.com/vllm-project/vllm.git

PACKAGE_VERSION=${1:-v0.6.3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the latest version 0.7.0 as default now?

npanpaliya
npanpaliya reviewed Jan 30, 2025
View reviewed changes
v/vllm/vllm_ubi_9.3.sh
cd $DEPS_DIR/audio
python -m pip install -v -e . --no-build-isolation &

wait $(jobs -p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope parallel execution doesn't kill your system. It may go OOM.

npanpaliya
npanpaliya reviewed Jan 30, 2025
View reviewed changes
v/vllm/vllm_ubi_9.3.sh
fi

python -m pip install pytest
if ! python -m pytest tests/test_sequence.py tests/test_inputs.py; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think let's cover all text related tests here.

npanpaliya
npanpaliya reviewed Jan 30, 2025
View reviewed changes
v/vllm/vllm_ubi_9.3.sh
# -----------------------------------------------------------------------------
#
# Package : vllm
# Version : v0.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update here too.

npanpaliya
npanpaliya approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@npanpaliya npanpaliya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments I've shared, rest LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npanpaliya npanpaliya npanpaliya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shafi-Hussain @npanpaliya