Currency: added build_script and build_info.json for xgboost v2.0.3 #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-dayma-ibm
requested changes
Jan 24, 2025
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": false, | ||
| "*": { | ||
| "build_script": "xgboost_ubi_9.3.sh" | ||
| "build_script": "xgboost_2.0.3_ubi_9.3.sh" |
There was a problem hiding this comment.
We should be having an extra block to locate xgboost_ubi_9.3.sh for version 1.6.2, instead replacing it in build_info.json.
x/xgboost/xgboost_2.0.3_ubi_9.3.sh
Outdated
| echo "Current directory: $(pwd)" | ||
|
|
||
| #as there is no setup.py file included in python-package | ||
| if ! (python3 -m build); then |
There was a problem hiding this comment.
We should be having install step here, instead of building. Once package is installed I don't we are hitting unit test cases.
There was a problem hiding this comment.
as there is no setup.py file included in python-package am building it directly and also there are no test cases.
There was a problem hiding this comment.
@shubham-dayma-ibm addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?