Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency: Updated build_script and build_info.json for pyarrow v15.0.1 #5347

Open
wants to merge 1 commit into
base: python-ecosystem
Choose a base branch
from
Open

Currency: Updated build_script and build_info.json for pyarrow v15.0.1 #5347

wants to merge 1 commit into from

Conversation

kiranNukal
Copy link
Contributor

Checklist

  • Have you checked and followed all the points mention in the CONTRIBUTING.MD
  • Have you validated script on UBI 9 container
  • Did you run the script(s) on fresh container with set -e option enabled and observe success ?
  • Did you have Legal approvals for patch files ?

shubham-dayma-ibm
shubham-dayma-ibm requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@shubham-dayma-ibm shubham-dayma-ibm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the comments, needs to be get reviewed by Amir and Deepali.
Also the PR status has to be open, instead of draft

p/pyarrow/build_info.json
"docker_build": false,
"validate_build_script": true,
"use_non_root_user": false,
"*": {
"build_script": "pyarrow_ubi_9.3.sh"
"build_script": "pyarrow_15.0.1_ubi_9.3.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be having a new block for older pyarrow versions, instead writing it off.

"*"{
   "build_script": "pyarrow_15.0.1_ubi_9.3.sh"
},
"*11.0.0"{
   "build_script": "pyarrow_ubi_9.3.sh"
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed.

p/pyarrow/pyarrow_15.0.1_ubi_9.3.sh Show resolved Hide resolved
@kiranNukal kiranNukal marked this pull request as ready for review January 24, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-dayma-ibm shubham-dayma-ibm shubham-dayma-ibm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiranNukal @shubham-dayma-ibm