Currency: added build_script and updated build_info.json for Matplotlib v3.8.0 #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-dayma-ibm
requested changes
Jan 24, 2025
| "validate_build_script": true, | ||
| "use_non_root_user": false, | ||
| "docker_build": false, | ||
| "v3.9.2": { | ||
| "build_script": "matplotlib_ubi_9.3.sh" | ||
| }, | ||
| "*":{ | ||
| "build_script":"matplotlib_3.7.1_ubi_9.3.sh" | ||
| "build_script":"matplotlib_3.8.0_ubi_9.3.sh" |
There was a problem hiding this comment.
Make sure build_info.json covers all the build-scripts available for different version. We can't remove 3.7.1 from here, if it was working for that version
|
PR should be in open state for review |
shubham-dayma-ibm
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?