-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - imported from other module #10
Conversation
da7e61a
to
8c274ea
Compare
8c274ea
to
fe87306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, so good I reckon.
@@ -38,13 +42,21 @@ export default class PodiumHttpClient { | |||
timeout = 500, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this timeout should be 1000. Wonder why @trygve-lie went for 500 🤔
I think for the Podium client, fallback as a string is more useful than fallback as a function. |
WIP - Creating an improved HTTP client which has a circuit breaker.
Note, these are just notes 😄
Todos
client
which we need to continue havingOpen questions ❓
request
which we are using here is single origin, which means that a request tohttps://google.com
returning alocation
header withhttps://www.google.com
will not redirect as it's a different host. the client implementation supportsredirectable
and it's used in the resolversalpha
to create a release?Errors
If
options.fallback
is not set, we wrap errors in aHttpClientError
class.Constructor options
abortController
we need to be able to cancel requests in opossum
followRedirects
if we should follow redirects or not, default behaviour is to not follow (???)
fallback
Closes #11