Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove build flavor in favor of build hook #708

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gilzow
Copy link
Contributor

@gilzow gilzow commented Dec 5, 2022

See #707
Changes build:flavor:composer to build:flavor: none and places composer install into the build hook with the following options:
--no-dev --no-progress --no-ansi --no-interaction --prefer-dist --optimize-autoloader

From #707 , the only thing not included are changes to akeneo and pimcore.

@gilzow gilzow requested a review from chadwcarlson December 5, 2022 19:22
@gilzow gilzow marked this pull request as draft December 5, 2022 21:30
@gilzow
Copy link
Contributor Author

gilzow commented Dec 5, 2022

Moved to draft status until we receive further feedback

@gilzow gilzow self-assigned this Dec 14, 2022
@Mupsi
Copy link
Contributor

Mupsi commented Dec 26, 2022

Hey Paul, I've got bad news: the docs link seems to have changed since you opened this! It's now https://docs.platform.sh/languages/php.html#change-the-build-flavor

@gilzow
Copy link
Contributor Author

gilzow commented Dec 28, 2022

@Mupsi updated.
🤞 they don't change the docs again before we finish this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants