Add the option to show abstracts on the issue page #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
reviewed
Feb 12, 2025
| */ | ||
| public function getAllSectionColors() { | ||
| $issueDao = DAORegistry::getDAO('IssueDAO'); | ||
| $issues = $issueDao->getPublishedIssues(Application::get()->getRequest()->getContext()->getId()); |
There was a problem hiding this comment.
Can we avoid this call? I'm worrying that it introduces additional database call to retrieve all issue objects per each request.
Vitaliy-1
reviewed
Feb 12, 2025
There was a problem hiding this comment.
We do need this CSS only for the issue page, right?
If using TemplateManager::display hook, is it possible then to do something like the following?
function addStyle(string $hookname, array $args)
{
$templateMgr = $args[0];
$template = $args[1];
if ($template !== "frontend/pages/issue.tpl") return false;
$issue = $templateMgr->getTemplateVars('issue');
$colors = $issue->getData('immersionSectionColor');
...
}
|
Thanks @ronste! I've made a comment regarding avoiding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Vitaliy-1 ,
as discussed here my PR to add a feature to show abstarcts on the issue page.
Currently there is a test installation available at http://ojs-dev-01.cedis.fu-berlin.de/index.php/tfj where you can see the frontend effect.
In the backend it looks like this:
This PR is for 3.3. I can prepare a 3.4 PR in a next step.
P.S.: Naturally I am not able to provide translations for all supported languages. I just add DE and EN.
Best wishes,
Ronald