fix!: update the format of conflic name from {name}$0 to {name}_1
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 100 100
Lines 12106 12106
Branches 1603 1603
=======================================
Hits 10793 10793
Misses 1262 1262
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous format was not friendly for reading and selecting on the editor. Double-clicking on
name$0will only selectnameinstead of the wholename$0. I would like to take this chance to update it to a different format. This might bring some unnecessary changes to downstream who need a consistent output. So I guess this will be the last time I adjust the naming rule.Another format would be to follow what babel does:
_{name}1. But I don't have a strong opinion on it.