Reverting reticule text background opacity back to 0.4 #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So - what needs to happen here is that the main flight UI elements need to be moved to a separate color name, as lightBlackBackground (horrible name) is used in a lot of places that should not be made less opaque. I'll look at it when I'm back from my break. |
|
Damn, I should have thought of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on discord by Admetus, the text background around the reticule is quite dark:
Makes sense on light backgrounds, but is distracting over dark:
This PR reverts back the 0.8 opacity to 0.4 in the theme:
In the long run I think it would be a better solution, if the blending mode of them would be Multiply. Then it would only darken, but not brighten. Not sure if that's easily and cheaply doable though.