Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context.go #300

Closed
wants to merge 1 commit into from
Closed

Update context.go #300

wants to merge 1 commit into from

Conversation

zcc0077
Copy link
Contributor

@zcc0077 zcc0077 commented Nov 29, 2024

error print is misleading due to wrong arg order

Description

Reference issue

Fixes print misleading

@Sean-Der
Copy link
Member

Thank you @zcc0077 !

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (b373975) to head (b2da902).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   78.78%   78.78%           
=======================================
  Files          17       17           
  Lines        1504     1504           
=======================================
  Hits         1185     1185           
  Misses        219      219           
  Partials      100      100           
Flag Coverage Δ
go 78.78% <100.00%> (ø)
wasm 78.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Expected/actual were flipped leading to incorrect error message
@JoeTurki
Copy link
Member

JoeTurki commented Jan 19, 2025

@zcc0077 Thank you so much, I had to rebase your PR because I don't have write access to your fork, your commit was pushed to master <3

@JoeTurki JoeTurki closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants