Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): add meta pkg and rename many names #6063

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

liubog2008
Copy link
Member

  • add meta pkg
  • rename many names defined in core to make sure they have same format

@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge February 7, 2025 06:51
@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 7, 2025
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 60.22727% with 35 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (39b6417) to head (943c6c3).

Additional details and impacted files
@@             Coverage Diff             @@
##           feature/v2    #6063   +/-   ##
===========================================
  Coverage       69.42%   69.43%           
===========================================
  Files             153      153           
  Lines            9688     9690    +2     
===========================================
+ Hits             6726     6728    +2     
  Misses           2962     2962           
Flag Coverage Δ
unittest 69.43% <60.22%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@liubog2008 liubog2008 added the v2 for operator v2 label Feb 7, 2025
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@fgksgf
Copy link
Member

fgksgf commented Feb 7, 2025

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed lgtm labels Feb 7, 2025
@liubog2008 liubog2008 force-pushed the liubo02/add-meta-pkg branch from bbd8a78 to 943c6c3 Compare February 7, 2025 09:15
@liubog2008
Copy link
Member Author

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 8, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, fgksgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-07 09:12:25.417131935 +0000 UTC m=+2187.813353989: ☑️ agreed by fgksgf.
  • 2025-02-07 09:12:36.382897843 +0000 UTC m=+2198.779119906: ✖️🔁 reset by ti-chi-bot[bot].
  • 2025-02-08 01:58:08.959903689 +0000 UTC m=+62531.356125750: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot merged commit fa5d80e into pingcap:feature/v2 Feb 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants