Opt: add volume name label to PVC #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #6059 +/- ##
==============================================
+ Coverage 69.41% 69.42% +0.01%
==============================================
Files 153 153
Lines 9684 9688 +4
==============================================
+ Hits 6722 6726 +4
Misses 2962 2962
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/run-pull-e2e-kind-v2 |
1 similar comment
|
/run-pull-e2e-kind-v2 |
liubog2008
reviewed
Feb 6, 2025
apis/core/v1alpha1/common_types.go
Outdated
| @@ -87,6 +87,8 @@ const ( | |||
| // LabelKeyStoreID is the unique identifier of a TiKV or TiFlash store. | |||
| // This label is used for backward compatibility with TiDB Operator v1, so it has a different prefix. | |||
| LabelKeyStoreID = "tidb.pingcap.com/store-id" | |||
|
|
|||
| LabelKeyVolumeName = LabelKeyPrefix + "volume-name" | |||
|
/run-pull-e2e-kind-v2 |
csuzhangxc
approved these changes
Feb 7, 2025
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.