Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: partials_as_hits for codecov #6019

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Dec 31, 2024

What problem does this PR solve?

ref https://docs.codecov.com/docs/codecovyml-reference#parsersgo

in go tool cover, partial coverage is considered as covered, but codecov doesn't by default

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the size/S label Dec 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.54%. Comparing base (7a1150d) to head (a28300c).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6019      +/-   ##
==============================================
+ Coverage       42.47%   45.54%   +3.07%     
==============================================
  Files             154      154              
  Lines           10130    10130              
==============================================
+ Hits             4303     4614     +311     
  Misses           5516     5516              
+ Partials          311        0     -311     
Flag Coverage Δ
unittest 45.54% <ø> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc enabled auto-merge (squash) December 31, 2024 06:01
@csuzhangxc csuzhangxc disabled auto-merge December 31, 2024 06:01
@csuzhangxc csuzhangxc merged commit 8ddd9ee into pingcap:feature/v2 Dec 31, 2024
6 of 7 checks passed
@csuzhangxc csuzhangxc deleted the ut4 branch December 31, 2024 06:02
liubog2008 pushed a commit to liubog2008/tidb-operator that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants