fix: type mismatch in TidbMonitor remoteTimeout

[IMMORTALxJO]

What problem does this PR solve?

Fix the bug where tidbmonitor.spec.prometheus.remoteWrite.remoteTimeout CRD only accepts integers:

Invalid value: "string": spec.prometheus.remoteWrite[0].remoteTimeout in body must be of type integer: "string"

However, if we pass an integer and check the operator logs, we will see that the operator fails to unmarshal the TiDBMonitor resource because it expected a string instead:

json: cannot unmarshal number into Go struct field RemoteWriteSpec.items.spec.prometheus.remoteWrite.remoteTimeout of type string

the definition of the struct field in code - here

What is changed and how does it work?

Changed field type in tidbmonitors CRD, from integer to string.

Code changes

• Has Go code change
• Has CI related scripts change

Tests

• Unit test
• E2E test
• Manual test
• No code

Side effects

• Breaking backward compatibility
• Other side effects:

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix type mismatch of `TidbMonitor` field `.spec.prometheus.remoteWrite.remoteTimeout`

[sre-bot]

All committers have signed the CLA.

[ti-chi-bot]

Welcome @IMMORTALxJO! It looks like this is your first PR to pingcap/tidb-operator 🎉

[csuzhangxc]

@IMMORTALxJO If we want to modify the CRD, we need to modify the Go struct in types.go and then re-generate the CRD (make generate)

[IMMORTALxJO]

@csuzhangxc thank you, I've added the missing file with Go struct.

[csuzhangxc]

@csuzhangxc thank you, I've added the missing file with Go struct.

It seems still need to re-generate other files, can you run make generate?

[IMMORTALxJO]

@csuzhangxc sorry for the delay, added make generate results to the commit.

[csuzhangxc]

@IMMORTALxJO can you fix the problem reported in CI? https://github.com/pingcap/tidb-operator/actions/runs/12186746269/job/34009983048?pr=5734

[IMMORTALxJO]

@csuzhangxc thank you, fixed tests, please check

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (a16b2e8) to head (c4e9f61).
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5734      +/-   ##
==========================================
+ Coverage   57.19%   63.09%   +5.89%     
==========================================
  Files         259      263       +4     
  Lines       33233    45660   +12427     
==========================================
+ Hits        19008    28807    +9799     
- Misses      12291    14845    +2554     
- Partials     1934     2008      +74     

Flag	Coverage Δ
e2e	45.64% <100.00%> (?)
unittest	56.96% <100.00%> (-0.23%)	⬇️

[csuzhangxc]

/run-all-tests

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-10 03:56:45.596224052 +0000 UTC m=+324395.685026596: ☑️ agreed by csuzhangxc.

[csuzhangxc]

/cherry-pick release-1.6

[ti-chi-bot]

@csuzhangxc: new pull request created to branch release-1.6: #5969.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.