Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update docker image of pingcap base to v1.9.1 (#5705) #5707

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5705

  • use the latest secure base image
  • use the official registry which the image will auto published to.
  • use the detail tag to make it reproducible.

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign liubog2008 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from KanShiori August 8, 2024 05:08
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.36%. Comparing base (d032996) to head (e865e8f).
Report is 15 commits behind head on release-1.5.

❗ There is a different number of reports uploaded between BASE (d032996) and HEAD (e865e8f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d032996) HEAD (e865e8f)
unittest 1 0
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.5    #5707       +/-   ##
================================================
- Coverage        61.53%   27.36%   -34.17%     
================================================
  Files              229      221        -8     
  Lines            29331    29979      +648     
================================================
- Hits             18050     8205     -9845     
- Misses            9499    20617    +11118     
+ Partials          1782     1157      -625     
Flag Coverage Δ
e2e 27.36% <ø> (?)
unittest ?

@csuzhangxc csuzhangxc merged commit a678a48 into pingcap:release-1.5 Aug 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants