fix UT

pingcap · Jan 13, 2025 · 957df63 · 957df63
1 parent c172158
commit 957df63
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 13 deletions.
diff --git a/pkg/controllers/tidb/tasks/pod_test.go b/pkg/controllers/tidb/tasks/pod_test.go
@@ -32,7 +32,7 @@ import (
 
 const (
 	fakeVersion = "v1.2.3"
-	podSpecHash = "9bbf8897b"
+	podSpecHash = "6cfdc7d895"
 )
 
 func TestTaskPod(t *testing.T) {

diff --git a/pkg/controllers/tiflash/tasks/pod_test.go b/pkg/controllers/tiflash/tasks/pod_test.go
@@ -30,7 +30,10 @@ import (
 	"github.com/pingcap/tidb-operator/pkg/utils/task/v3"
 )
 
-const fakeVersion = "v1.2.3"
+const (
+	fakeVersion = "v1.2.3"
+	podSpecHash = "5575684b96"
+)
 
 func TestTaskPod(t *testing.T) {
 	cases := []struct {
@@ -123,7 +126,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tiflash-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "556796549d",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),
@@ -147,7 +150,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tiflash-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "old",
-							v1alpha1.LabelKeyPodSpecHash: "556796549d",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),
@@ -171,7 +174,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tiflash-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "556796549d",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 							"xxx":                        "yyy",
 						}
 						return obj
@@ -196,7 +199,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tiflash-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "556796549d",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 							"xxx":                        "yyy",
 						}
 						return obj
@@ -222,7 +225,7 @@ func TestTaskPod(t *testing.T) {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyInstance:    "aaa-xxx",
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "556796549d",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),

diff --git a/pkg/controllers/tikv/tasks/pod_test.go b/pkg/controllers/tikv/tasks/pod_test.go
@@ -33,7 +33,10 @@ import (
 	"github.com/pingcap/tidb-operator/pkg/utils/task/v3"
 )
 
-const fakeVersion = "v1.2.3"
+const (
+	fakeVersion = "v1.2.3"
+	podSpecHash = "6b85d6945f"
+)
 
 func TestTaskPod(t *testing.T) {
 	now := metav1.Now()
@@ -173,7 +176,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tikv-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "59f798884b",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),
@@ -197,7 +200,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tikv-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "old",
-							v1alpha1.LabelKeyPodSpecHash: "59f798884b",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),
@@ -221,7 +224,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tikv-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "59f798884b",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 							"xxx":                        "yyy",
 						}
 						return obj
@@ -246,7 +249,7 @@ func TestTaskPod(t *testing.T) {
 					pod: fake.FakeObj("aaa-tikv-xxx", func(obj *corev1.Pod) *corev1.Pod {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "59f798884b",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 							"xxx":                        "yyy",
 						}
 						return obj
@@ -272,7 +275,7 @@ func TestTaskPod(t *testing.T) {
 						obj.Labels = map[string]string{
 							v1alpha1.LabelKeyInstance:    "aaa-xxx",
 							v1alpha1.LabelKeyConfigHash:  "newest",
-							v1alpha1.LabelKeyPodSpecHash: "59f798884b",
+							v1alpha1.LabelKeyPodSpecHash: podSpecHash,
 						}
 						return obj
 					}),