Allowing doctrine3 #56
Merged
+42
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
updating_to_doctrine3
branch
from
0ea814d to
a1f0478
Compare
mamazu
force-pushed
the
updating_to_doctrine3
branch
from
a1f0478 to
40d7650
Compare
mamazu
commented
Jan 17, 2025
| @@ -62,7 +64,7 @@ public function remove(TaskInterface $task) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function findAll($page = 1, $pageSize = null) | |||
| public function findAll($page = 1, $pageSize = null): array | |||
There was a problem hiding this comment.
This one is required by doctrine 3.
There was a problem hiding this comment.
I'd recommend not "overriding" this method in the first place as it has different parameters in the default implementation and could possibly be very confusing.
There was a problem hiding this comment.
@mamazu yeah 😂 after a few year i would not do that again. Maybe i will rework the repository in the future! for now the change is good.
|
@wachterjohannes According to Alexander you should be the best person to review this. |
|
@mamazu thanks for the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new version of doctrine 3 the
EntityRepositoryhas a property which uses an intersection type this confused the prophecy. This is why I needed to add a new interface to the application.