Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fabs() function instead abs() #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Using fabs() function instead abs() #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion geospatial.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ geo_lat_long cartesian_to_polar(double x, double y, double z, geo_ellipsoid eli)
double phi = atan2(z, p * (1 - eSq));
double phiP = 2 * M_PI;

while (abs(phi - phiP) > precision) {
while (fabs(phi - phiP) > precision) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR made one of the tests fail: https://travis-ci.org/php-geospatial/geospatial/jobs/351708921#L643

Can you investigate whether the new value is correct, as the loop where you changed abs to fabs might now run once more or less?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have warning when compile geospatil.so in FreeBSD 10.3. Warning saying about using fabs instead abs. When I changed abs to fabs warning is gone!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, but it breaks a test if you change it. So either the test is wrong, or something else is going on.

nu = eli.a / sqrt(1 - eSq * sin(phi) * sin(phi));
phiP = phi;
phi = atan2(z + eSq * nu * sin(phi), p);
Expand Down