-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output maf version number with "--mafversion" #96
Conversation
Currently it is partly working but not complete. To check version numbers, The current problem is, when using maf in the git repository (where |
The problem above is rather complicated. First, I found a snippet in waflib where For this, when loading We skip this problem by not checking version in |
Thanks for supporting versioning. LGTM with one comment. If one migrates from old version that does not define MAFVERSION to the new version with MAFVERSION, an exception |
LGTM! |
Incomplete implementation for #89.
Currently maf.py obtain the revision number of git, but now maflib cannot access to it.
We have to implement core.ExpOptionsContext.init. The version is now a constant of in maf.py, but we cannot access this number from maflib. Maybe we have to make an auto generated file in .waf-*/maflib directory to save some constants.