-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAFE Wallet Account Abstraction ERC 4337 fix #480
SAFE Wallet Account Abstraction ERC 4337 fix #480
Conversation
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pendulum-chain/devs Ready for review ✅ |
One thing worth mentioning is that for setting the maximum and current number of signers, we use Zustand outside of a React component and custom hook, directly within a plain function. https://github.com/pmndrs/zustand#readingwriting-state-and-reacting-to-changes-outside-of-components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, looks good to me in general 🙏 I only left some questions regarding the structure.
@pendulum-chain/devs Ready ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should test one offramp, if you haven't already. Do you have a safe wallet to test?
@gianfra-t I tested 2 days ago, should I test again? |
We can test on staging then, to save some funds. |
Yes, let's do that 👍 |
The SAFE Wallet AA Issue
When using Safe Wallet, the initial transaction hash returned is a safeTxHash which differs from the final on-chain transaction hash. This is because Safe uses a multi-signature approach where:
This creates challenges when tracking transaction status using standard wagmi/viem hooks, as they look for the initial safeTxHash on-chain which doesn't exist.
Instead of wagmi
waitForTransactionReceipt
use