Skip to content

Commit

Permalink
Try pinning lcov to v2.0
Browse files Browse the repository at this point in the history
For compatabilty with Ubuntu.
  • Loading branch information
pcolby committed Dec 22, 2024
1 parent 5207735 commit d6ce261
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ permissions:

jobs:
linux:
if: false
runs-on: ubuntu-24.04
strategy:
fail-fast: false
Expand Down Expand Up @@ -168,7 +169,7 @@ jobs:
- macos-14
- macos-15
cc:
- clang
#- clang

Check warning on line 172 in .github/workflows/build.yaml

View workflow job for this annotation

GitHub Actions / yamllint

172:12 [comments] missing starting space in comment
- gcc
exclude:
# GitHub's macOS 14+ gcc can only target arm64, but Qt didn't add Apple arm64 support until Qt 6.2, so:
Expand Down Expand Up @@ -200,7 +201,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install lcov
run: brew install lcov --head # \todo Remove when lcov commit b34c844 is released.
run: brew install lcov@2.0 # \todo Remove when lcov commit b34c844 is released.
# \todo See https://github.com/linux-test-project/lcov/commit/b34c84431a97b49e55785286fa05e9a95b873920
- name: Install Qt
uses: jurplel/install-qt-action@v4
Expand Down Expand Up @@ -282,7 +283,7 @@ jobs:
if: matrix.os != 'macos-13' || matrix.cc == 'gcc'
run: cmake --build "$RUNNER_TEMP/coverage" --target coverage
- name: Upload test results
if: matrix.os != 'macos-13' || fromJSON(steps.build.outputs.tap)
#if: matrix.os != 'macos-13' || fromJSON(steps.build.outputs.tap)

Check warning on line 286 in .github/workflows/build.yaml

View workflow job for this annotation

GitHub Actions / yamllint

286:10 [comments] missing starting space in comment
uses: actions/upload-artifact@v4
with:
name: test-results-${{ steps.build.outputs.dokitVersion }}
Expand Down Expand Up @@ -321,6 +322,7 @@ jobs:
if-no-files-found: error

win:
if: false
runs-on: windows-latest
defaults: { run: { shell: cmd } }
strategy:
Expand Down Expand Up @@ -617,7 +619,8 @@ jobs:
if-no-files-found: error

collate-test-results:
needs: [ linux, mac, win ]
#needs: [ linux, mac, win ]

Check warning on line 622 in .github/workflows/build.yaml

View workflow job for this annotation

GitHub Actions / yamllint

622:6 [comments] missing starting space in comment
needs: [ mac ]
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit d6ce261

Please sign in to comment.