Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes now have to have different names #990

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Attributes now have to have different names #990

merged 9 commits into from
Jan 20, 2025

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis January 17, 2025 15:13
ilestis
ilestis requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks. ALso does this trigger when saving an entity for the first time?

app/Http/Requests/UpdateAttributes.php Outdated Show resolved Hide resolved
app/Services/AttributeService.php Outdated Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis January 20, 2025 15:34
ilestis
ilestis requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not in the API

app/Http/Controllers/CrudController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entities/CreateController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Entities/EditController.php Outdated Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis January 20, 2025 17:54
@ilestis ilestis merged commit 9c0b270 into develop Jan 20, 2025
1 of 2 checks passed
@ilestis ilestis deleted the attributes-different-name branch January 20, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilestis ilestis ilestis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spitfire305 @ilestis