Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/fs): fs.close and fs.Dir.closeSync #16686

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

Closes #16622

  • fix misnamed closedirSync call to closeSync (if only we had type checking...
  • fill in method stub for fs.Dir.prototype.closeSync
  • throw ERR_DIR_CLOSED when dir.read[Sync]() is called after dir.close[Sync]()'

How did you verify your code works?

I added tests

@robobun
Copy link

robobun commented Jan 24, 2025

Updated 3:19 AM PT - Jan 24th, 2025

@DonIsaac, your commit 14c9309 has 3 failures in #10447:


🧪   try this PR locally:

bunx bun-pr 16686

@staabm
Copy link
Contributor

staabm commented Jan 24, 2025

the added file is empty

grafik

@Jarred-Sumner Jarred-Sumner merged commit 0d53353 into main Jan 24, 2025
67 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the don/fix/fs-close branch January 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing closedirSync in fs
4 participants