Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bottle upload and drop Big Sur #325

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

fauxpark
Copy link
Contributor

Prereq for #324, and all other fixes that must go in before it.

@fauxpark
Copy link
Contributor Author

brew style failures need to be solved in a separate, followup PR. What a mess.

@fauxpark fauxpark changed the title Fix bottle upload Fix bottle upload and drop Big Sur Feb 23, 2024
@fauxpark
Copy link
Contributor Author

Big Sur can also be dropped as Monterey is now the minimum supported version for Brew.

@ladislas
Copy link
Member

brew style failures need to be solved in a separate, followup PR. What a mess.

I've created a PR here for that #327

once it's green, I'll rebase your PR or cherry pick your changes in a new PR

@fauxpark
Copy link
Contributor Author

This PR needs to go in first; the upload-artifact action is broken - see above.

@ladislas
Copy link
Member

@fauxpark I've also update the actions in another PR #328

@fauxpark
Copy link
Contributor Author

That's what this PR does already... nothing will be green until this PR goes in.

@ladislas
Copy link
Member

Sorry I got confused.
You upgraded to v3. Any reason not to use v4?

@ladislas ladislas merged commit 1e92c8f into osx-cross:main Mar 11, 2024
0 of 2 checks passed
@fauxpark fauxpark deleted the fix-bottle-upload branch March 11, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants