Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Component]: Breadcrumb Component (Work in progress) #861
base: develop
Are you sure you want to change the base?
[Component]: Breadcrumb Component (Work in progress) #861
Changes from all commits
00f6477
a84de3f
39ad974
2b90fe6
882ea57
6a6be85
7a4cbcc
575ff24
640d6f1
f70d7dd
09ea8d9
dd27602
e8415c6
01f9753
8376d97
acfc6ba
38fb1a6
152facb
4efbb07
c3dd07d
d184468
dcdc4b3
410ff47
216ca1d
9b173a8
605a9d2
e7662d4
984e6a8
48898e9
d44f0e9
759c2f7
b916416
3c9c588
80cbd4b
1ede02f
a06468f
a037ab6
00727cd
416de14
9f40b16
724a633
b99948d
18ddf61
a1fbf54
2aee214
0bb9baa
49d619a
ca0069c
11191e5
290989f
292c730
4882455
879b49a
59b05ea
48d58c5
f4fc3c8
5b8c1cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the separator class for? I would think of a class on the separator element, but not on the root with a suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use the component like
And the component would render the current route with its breadcumb items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider the sperator to be some html element.