This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
ElasticSearch 7 compatibility #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An actual bug. Filter object may have contained objects and arrays with objects. While ES 6.8 was lenient on this, ES 7 is no more.
- Bump elasticsearch package - Handle .hits.total change
patrickvenetz
force-pushed
the
pae/feat-es7-compat
branch
from
08e0afc to
06b864c
Compare
track_total_hits will get an accurate (but "costly") document count.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request allows us to use ElasticSearch 7.
Major change: In ElasticSearch 6,
hits.totalis an integer. In ElasticSearch 7,hits.totalis an object, returning document count asvalueandrelationof count. We usetrack_total_hitsflag to get an accurate (but "costly") document count.Bugfix: We may have passed a filter array containing objects and arrays with objects. While ElasticSearch prior to version 7 was lenient on this, version 7 isn't anymore and will throw a parsing exception.
Fixes #616