[XLA:LatencyHidingScheduler] Let GetResourcesFromInstruction return a complete list of resources used by instructions in a while loop. This will make async done and while ops have similar priority (in terms of occupying resource types) and avoid delaying the while loops only because they cross the overlap limit (even though they have a higher async depth).
#22119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_721121051
branch
from
c8675f8 to
2a69876
Compare
copybara-service
bot
changed the title
GetResourcesFromInstruction return a complete list of resources used by instructions in a while loop. This will make async done and while ops have similar priority (in terms of occupying resource types) and avoid delaying the while loops only because they cross the overlap limit.GetResourcesFromInstruction return a complete list of resources used by instructions in a while loop. This will make async done and while ops have similar priority (in terms of occupying resource types) and avoid delaying the while loops only because they cross the overlap limit (even though they have a higher async depth).
copybara-service
bot
force-pushed
the
test_721121051
branch
7 times, most recently
from
1c11488 to
5d58fd6
Compare
… a complete list of resources used by instructions in a while loop. This will make async `done` and while ops have similar priority (in terms of occupying resource types) and avoid delaying the while loops only because they cross the overlap limit (even though they have a higher async depth). This CL also fixes the double counting of a resource in `GetNumResourcesPerInstruction` because of multiple async `done` ops in the while body. PiperOrigin-RevId: 725375955
copybara-service
bot
force-pushed
the
test_721121051
branch
from
5d58fd6 to
7f161ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:LatencyHidingScheduler] Let
GetResourcesFromInstructionreturn a complete list of resources used by instructions in a while loop. This will make asyncdoneand while ops have similar priority (in terms of occupying resource types) and avoid delaying the while loops only because they cross the overlap limit (even though they have a higher async depth).This CL also fixes the double counting of a resource in
GetNumResourcesPerInstructionbecause of multiple asyncdoneops in the while body.