Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of Object.keys() #2054

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions browser-extensions.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"nordpass": {
[
{
"key": "nordpass",
"name": "NordPass",
caugner marked this conversation as resolved.
Show resolved Hide resolved
"message": "NordPass performs polyfill-like transformations on navigator.credentials, affecting tests for the CredentialsContainer API.",
"affectedTests": ["api.CredentialsContainer"],
"chromeId": "eiaeiblijfjekdanodkjadfinkhbfgcd",
"firefoxId": "0ff38d7a-db91-4a1a-a222-00f10d098b22",
"safariId": "9F9F9D62-DE32-4B4F-88FD-63D448DACFDC"
}
}
]
7 changes: 4 additions & 3 deletions static/resources/harness.js
Original file line number Diff line number Diff line change
Expand Up @@ -1747,9 +1747,10 @@
renderHarnessLink(resultsEl);

// Render code and support for reusable instances
var reInstKeys = Object.keys(reusableInstances.__sources);
for (var i = 0; i < reInstKeys.length; i++) {
renderReInstReportEl(reInstKeys[i], resultsEl);
for (var key in reusableInstances.__sources) {
if (Object.prototype.hasOwnProperty.call(reusableInstances.__sources, key)) {
renderReInstReportEl(reusableInstances.__sources[key], resultsEl);
}
}

// Add divider
Expand Down
6 changes: 2 additions & 4 deletions views/extensioncheck.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,11 @@ See the LICENSE file for copyright details
return;
}

var extensionsToCheck = Object.keys(extensions);
var remaining = extensionsToCheck.length;
var remaining = extensions.length;

var foundExtensions = [];

extensionsToCheck.forEach(function(k) {
var extension = extensions[k];
extensions.forEach(function(extension) {
checkExtension(extension, function(result) {
if (result) {
foundExtensions.push(k);
Expand Down
Loading