stops using "contradictions" terminology

openwebdocs · Dec 7, 2023 · f27f002 · f27f002
1 parent 09eb95a
commit f27f002
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 18 deletions.
diff --git a/scripts/update-bcd.test.ts b/scripts/update-bcd.test.ts
@@ -19,7 +19,7 @@ import {
   findEntry,
   getSupportMap,
   getSupportMatrix,
-  hasSupportMatrixContradictions,
+  hasSupportUpdates,
   inferSupportStatements,
   splitRange,
   update,
@@ -825,25 +825,23 @@ describe("BCD updater", () => {
   describe("hasSupportMatrixContradictions", () => {
     it("detects contradictions with nonexistent support statements", () => {
       assert.isTrue(
-        hasSupportMatrixContradictions(new Map([["80", true]]), {
+        hasSupportUpdates(new Map([["80", true]]), {
           version_added: null,
         }),
       );
 
-      assert.isTrue(
-        hasSupportMatrixContradictions(new Map([["80", true]]), undefined),
-      );
+      assert.isTrue(hasSupportUpdates(new Map([["80", true]]), undefined));
     });
 
     it("skips null support claims", () => {
       assert.isFalse(
-        hasSupportMatrixContradictions(new Map([["80", null]]), {
+        hasSupportUpdates(new Map([["80", null]]), {
           version_added: "≤80",
         }),
       );
 
       assert.isFalse(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", true],
@@ -860,21 +858,21 @@ describe("BCD updater", () => {
 
     it("detects contradictions in statements with boolean values", () => {
       assert.isFalse(
-        hasSupportMatrixContradictions(new Map([["80", false]]), {
+        hasSupportUpdates(new Map([["80", false]]), {
           version_added: false,
         }),
         "skips generic false statements",
       );
 
       assert.isTrue(
-        hasSupportMatrixContradictions(new Map([["80", true]]), {
+        hasSupportUpdates(new Map([["80", true]]), {
           version_added: true,
         }),
         "catches specific support updates over generic true statements",
       );
 
       assert.isTrue(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["80", false],
             ["81", true],
@@ -886,7 +884,7 @@ describe("BCD updater", () => {
 
     it("detects contradictions in statements with string values", () => {
       assert.isTrue(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", false],
@@ -899,7 +897,7 @@ describe("BCD updater", () => {
       );
 
       assert.isFalse(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", false],
@@ -912,7 +910,7 @@ describe("BCD updater", () => {
       );
 
       assert.isFalse(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", true],
@@ -925,7 +923,7 @@ describe("BCD updater", () => {
       );
 
       assert.isTrue(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", true],
@@ -940,7 +938,7 @@ describe("BCD updater", () => {
       );
 
       assert.isTrue(
-        hasSupportMatrixContradictions(
+        hasSupportUpdates(
           new Map([
             ["79", false],
             ["80", true],

diff --git a/scripts/update-bcd.ts b/scripts/update-bcd.ts
@@ -684,7 +684,7 @@ const skipCurrentBeforeSupport = skip("currentBeforeSupport", ({
   }
 });
 
-export const hasSupportMatrixContradictions = (
+export const hasSupportUpdates = (
   versionMap: BrowserSupportMap,
   simpleStatement?: SimpleSupportStatement,
 ) => {
@@ -972,7 +972,7 @@ export const update = (
       shared: {versionMap},
       defaultStatements: [simpleStatement],
     }) => {
-      if (!hasSupportMatrixContradictions(versionMap, simpleStatement)) {
+      if (!hasSupportUpdates(versionMap, simpleStatement)) {
         return reason(
           ({path, browser}) =>
             `$${path} skipped for ${browser} because support matrix matches current BCD support data`,
@@ -1035,7 +1035,7 @@ export const update = (
       shared: {versionMap},
     }) => {
       if (!statements?.length) {
-        if (hasSupportMatrixContradictions(versionMap, simpleStatement)) {
+        if (hasSupportUpdates(versionMap, simpleStatement)) {
           return reason(
             ({browser, path}) =>
               `${path} skipped for ${browser} with unresolved differences between support matrix and BCD data. Possible intervention required.`,