Change dialog invoke actions to close rather than cancel #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
lukewarlow
commented
Nov 16, 2023
| | `<dialog>` | `'toggleModal'` | If the `<dialog>` is not `open`, call `showModal()`, otherwise cancel the dialog | | ||
| | `<dialog>` | `'cancel'` | If the `<dialog>` is `open`, cancel the dialog | | ||
| | `<dialog>` | `'auto'` | If the `<dialog>` is not `open`, call `showModal()`, otherwise close the dialog | | ||
| | `<dialog>` | `'toggleModal'` | If the `<dialog>` is not `open`, call `showModal()`, otherwise close the dialog | |
There was a problem hiding this comment.
Should the auto and toggleModal (and toggle see #936 ) actions also use button value for the returnValue when closing?
lukewarlow
force-pushed
the
invokers-dialog-cancel
branch
from
d484bdb to
636aeee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937 and #938