Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP headers to GraphiQL, upgrade version #6380

Merged

Conversation

leonardehrenfried
Copy link
Member

Summary

One of my deployments is using rate limiting and API keys so I would like to be able to set headers in GraphiQL, which this PR adds.

While I was there I also upgraded GraphiQL to the latest version.

cc @fahrplaner

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (71bb5fa) to head (ed16268).
Report is 11 commits behind head on dev-2.x.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6380      +/-   ##
=============================================
- Coverage      69.80%   69.80%   -0.01%     
+ Complexity     17942    17941       -1     
=============================================
  Files           2046     2046              
  Lines          76671    76671              
  Branches        7830     7830              
=============================================
- Hits           53520    53518       -2     
- Misses         20408    20411       +3     
+ Partials        2743     2742       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@optionsome optionsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate that the UI doesn't really give hints in what format the headers/variables should be provided in (apart from the error messages).

@leonardehrenfried leonardehrenfried merged commit ce6fc7a into opentripplanner:dev-2.x Jan 15, 2025
5 checks passed
@leonardehrenfried leonardehrenfried deleted the graphiql-headers branch January 15, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants