Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf, OSM parser and Google cloud tools #6342

Merged
6 changes: 3 additions & 3 deletions application/pom.xml
Original file line number Diff line number Diff line change
@@ -312,9 +312,9 @@
</dependency>
<!-- OpenStreetMap protobuf (PBF) definitions and parser -->
<dependency>
<groupId>org.openstreetmap.osmosis</groupId>
<artifactId>osmosis-osm-binary</artifactId>
<version>0.48.3</version>
<groupId>org.openstreetmap.pbf</groupId>
<artifactId>osmpbf</artifactId>
<version>1.6.0</version>
</dependency>
<!-- Command line parameter parsing -->
<dependency>
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package org.opentripplanner.osm;

import crosby.binary.BinaryParser;
import crosby.binary.Osmformat;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import org.openstreetmap.osmosis.osmbinary.BinaryParser;
import org.openstreetmap.osmosis.osmbinary.Osmformat;
import org.opentripplanner.graph_builder.module.osm.OsmDatabase;
import org.opentripplanner.osm.model.OsmMemberType;
import org.opentripplanner.osm.model.OsmNode;
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package org.opentripplanner.osm;

import crosby.binary.file.BlockInputStream;
import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.time.ZoneId;
import org.openstreetmap.osmosis.osmbinary.file.BlockInputStream;
import org.opentripplanner.datastore.api.DataSource;
import org.opentripplanner.datastore.api.FileType;
import org.opentripplanner.datastore.file.FileDataSource;
Original file line number Diff line number Diff line change
@@ -62,7 +62,7 @@ protected void runPolling() throws InterruptedException, ExecutionException {
final FeedMessage feed = otpHttpClient.getAndMap(
URI.create(url),
this.headers.asMap(),
FeedMessage.PARSER::parseFrom
FeedMessage::parseFrom
);

long feedTimestamp = feed.getHeader().getTimestamp();
Original file line number Diff line number Diff line change
@@ -138,7 +138,7 @@ public void messageArrived(String topic, MqttMessage message) {
UpdateIncrementality updateIncrementality = FULL_DATASET;
try {
// Decode message
GtfsRealtime.FeedMessage feedMessage = GtfsRealtime.FeedMessage.PARSER.parseFrom(
GtfsRealtime.FeedMessage feedMessage = GtfsRealtime.FeedMessage.parseFrom(
message.getPayload()
);
List<GtfsRealtime.FeedEntity> feedEntityList = feedMessage.getEntityList();
Original file line number Diff line number Diff line change
@@ -221,7 +221,7 @@ protected void setUp() throws Exception {

try {
InputStream inputStream = new FileInputStream(gtfsRealTime);
FeedMessage feedMessage = FeedMessage.PARSER.parseFrom(inputStream);
FeedMessage feedMessage = FeedMessage.parseFrom(inputStream);
List<FeedEntity> feedEntityList = feedMessage.getEntityList();
List<TripUpdate> updates = new ArrayList<>(feedEntityList.size());
for (FeedEntity feedEntity : feedEntityList) {
3 changes: 2 additions & 1 deletion gtfs-realtime-protobuf/pom.xml
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@
<artifactId>gtfs-realtime-protobuf</artifactId>
<name>OpenTripPlanner - GTFS Realtime (protobuf)</name>


<dependencies>
<dependency>
<groupId>com.google.protobuf</groupId>
@@ -46,7 +47,7 @@
</execution>
</executions>
<configuration>
<protocArtifact>com.google.protobuf:protoc:3.22.0:exe:${os.detected.classifier}</protocArtifact>
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}:exe:${os.detected.classifier}</protocArtifact>
</configuration>
</plugin>
</plugins>
31 changes: 21 additions & 10 deletions pom.xml
Original file line number Diff line number Diff line change
@@ -59,20 +59,24 @@

<properties>
<otp.serialization.version.id>176</otp.serialization.version.id>

<!-- Lib versions - keep list sorted on property name -->
<geotools.version>32.1</geotools.version>
<google.dagger.version>2.53</google.dagger.version>
<jackson.version>2.18.2</jackson.version>
<jaxb-runtime.version>4.0.5</jaxb-runtime.version>
<jersey.version>3.1.9</jersey.version>
<junit.version>5.11.4</junit.version>
<micrometer.version>1.14.2</micrometer.version>
<micrometer.version>1.14.1</micrometer.version>
<netcdf4.version>5.6.0</netcdf4.version>
<logback.version>1.5.12</logback.version>
<lucene.version>10.1.0</lucene.version>
<slf4j.version>2.0.16</slf4j.version>
<micrometer.version>1.14.1</micrometer.version>
<netex-java-model.version>2.0.15</netex-java-model.version>
<netcdf4.version>5.6.0</netcdf4.version>
<protobuf.version>4.28.3</protobuf.version>
<siri-java-model.version>1.28</siri-java-model.version>
<jaxb-runtime.version>4.0.5</jaxb-runtime.version>
<slf4j.version>2.0.16</slf4j.version>
<!-- Other properties -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<GITHUB_REPOSITORY>opentripplanner/OpenTripPlanner</GITHUB_REPOSITORY>
@@ -389,14 +393,26 @@
<dependencyManagement>
<dependencies>
<dependency>
<!-- This make sure all google libraries are using compatible versions. -->
<!-- This makes sure all google libraries are using compatible versions. -->
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.48.0</version>
<version>26.51.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>${protobuf.version}</version>
</dependency>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>33.4.0-jre</version>
</dependency>

<!-- Logging API -->
<dependency>
<groupId>org.slf4j</groupId>
@@ -419,11 +435,6 @@
<artifactId>trove4j</artifactId>
<version>3.0.3</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>33.4.0-jre</version>
</dependency>

<!-- GEOTOOLS AND JTS TOPOLOGY: geometry, rasters and projections. -->
<!-- GEOTOOLS includes JTS as a transitive dependency. -->