Remove fare service from Graph

[leonardehrenfried]

Summary

This removes the fare service from the Graph instance and lets Dagger manage it instead.

Unit tests

A few unit tests had to be adjusted.

Bumping the serialization version id

✔️

[codecov]

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (1030408) to head (2e2b3da).
Report is 41 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...n/java/org/opentripplanner/standalone/OTPMain.java	0.00%	2 Missing ⚠️
...entripplanner/apis/gtfs/GraphQLRequestContext.java	0.00%	1 Missing ⚠️
...ner/standalone/configure/ConstructApplication.java	0.00%	1 Missing ⚠️
...pplanner/standalone/configure/LoadApplication.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6292      +/-   ##
=============================================
- Coverage      69.73%   69.72%   -0.02%     
+ Complexity     18024    18018       -6     
=============================================
  Files           2057     2057              
  Lines          76970    76978       +8     
  Branches        7846     7845       -1     
=============================================
- Hits           53678    53674       -4     
- Misses         20545    20553       +8     
- Partials        2747     2751       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[habrahamsson-skanetrafiken]

Why do we create the fareService here instead of in the loadApp.appConstruction() like the other ones?

Doesn't this mean that we will always get a DefaultFareService during graph build? And then overwrite that DefaultFareService with whatever this factory returns?

And if you run with --build --serve you will always use the DefaultFareService from the loadApp.constructApplication(). Or is it just me that don't understand how this hangs together?

[leonardehrenfried]

Since this PR is so old I had to get into it again: the reason why it is so strange is that the fareServiceFactory acts a builder gathering up fares data from all input feeds. It actually lives in the build config and is life-cycle managed and serialized through that.

No doubt this is terrible. It should really be part of the OtpTransitServiceBuilder which fulfills the same role.

I would like to request to not make this PR any bigger and let me revisit this topic.