automatically download adjacent ways when splitting a line #10615
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
| // display the loading indicator | ||
| button.classed('loading', true); | ||
| context.loadEntity(d.relation.id, function() { | ||
| if (d.relation.members.length > 250) { |
There was a problem hiding this comment.
If the relation has more than ~300 members, clicking the button will crash iD.
In my experience, 300 members isn’t that extreme and definitely wouldn’t risk a crash in general. A mid-sized U.S. state or a statewide bike trail would easily surpass this threshold. A confirmation dialog wouldn’t hurt, but the wording doesn’t need to be so certain and alarming. If this prevents the user from downloading the full relation, that could be unfortunate. Is there any way we could offer a third option to download the full relation at your own risk?
Mainland Australia1 has 3,583 members, which is a lot, but downloading it works for me without crashing in Firefox 134. It’s just very slow. I regularly work with large boundary relations in OpenHistoricalMap’s fork of iD that don’t incur any noticeable performance penalty. The performance issue is probably a function of the total number of nodes rather than the number of members, and maybe other factors too. For example, this multipolygon, which represents some marshes on the outskirts of San José, California, has only three members, but drawing an area that intersects it slows down iD even more than mainland Australia for me.
Footnotes
-
Why the heck is there a
boundaryrelation for a continent? ↩
There was a problem hiding this comment.
yeah, I wonder if this is the total wrong approach. #10316 is the root of the problem, which this doesn't even't solve. This is more of a hack so I can edit my local beach 😅
I'm starting to think that we need a different popup which interrupts the split operation, and offers to download the prev+next members. And then we leave this download button alone.
There was a problem hiding this comment.
okay, I've completely the changed the approach, so it directly solves #10469 by interrupting the split operation, rather than the Download Full Relation button
k-yle
force-pushed
the
kh/cant-split-way
branch
from
8431f3b to
42bada7
Compare
k-yle
changed the title
Closes #10469, Closes #10316
This error message has been removed:
and replaced with a popup that allows you to download the adjacent relation members and then continue the split operation: