Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported param for aro hcp deprovision #60347

Merged

Conversation

heliubj18
Copy link
Contributor

@heliubj18 heliubj18 commented Jan 6, 2025

remove unsupported param --skip-service-principal-deletion

@heliubj18 heliubj18 changed the title remove unsupported param remove unsupported param for aro hcp deprovision Jan 6, 2025
@openshift-ci-robot
Copy link
Contributor

@heliubj18, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/cucushift-installer-rehearse-azure-aks-hypershift-ephemeral-creds-deprovision: parameter "HYPERSHIFT_AZURE_CP_MI" is overridden in [chain/cucushift-installer-rehearse-azure-aks-hypershift-ephemeral-creds-deprovision] but not declared in any step, workflow/cucushift-installer-rehearse-azure-aks-hypershift-ephemeral-creds-guest: chain/cucushift-installer-rehearse-azure-aks-hypershift-ephemeral-creds-deprovision: parameter "HYPERSHIFT_AZURE_CP_MI" is overridden in [chain/cucushift-installer-rehearse-azure-aks-hypershift-ephemeral-creds-deprovision] but not declared in any step]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18 heliubj18 force-pushed the remove-unsupported-parm branch from f05e8da to aaad179 Compare January 6, 2025 18:12
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@heliubj18: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.20-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.19-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.18-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.17-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-azure-aks-hypershift-guest-reversed-f14 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-azure-aks-ovn-conformance N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-multi-nightly-azure-aks-hypershift-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-upgrade-from-stable-4.17-azure-aks-hypershift-byo-vnet-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.18-azure-aks-hypershift-etcd-disk-encryption-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-4.19-upgrade-from-stable-4.18-azure-aks-hypershift-registry-overrides-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-azure-aks-hypershift-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.17-azure-aks-hypershift-byo-vnet-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-ext-oidc-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-ephemeral-creds-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-registry-overrides-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-byo-vnet-fips-guest-f14-longduration N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-cilium-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-azure-aks-hypershift-full-cert-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-disaster-recovery-infra-guest-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-upgrade-from-stable-4.17-azure-aks-hypershift-etcd-disk-encryption-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-upgrade-from-stable-4.17-azure-aks-hypershift-byo-vnet-inplace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-cilium-guest-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-upgrade-from-stable-4.17-azure-aks-hypershift-registry-overrides-replace-guest-f28 N/A periodic Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-azure-aks-ovn-conformance N/A periodic Registry content changed

A total of 60 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@heliubj18
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance

@openshift-ci-robot
Copy link
Contributor

@heliubj18: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@heliubj18
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-ephemeral-creds-guest-f7

@openshift-ci-robot
Copy link
Contributor

@heliubj18: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@heliubj18
Copy link
Contributor Author

INFO[2025-01-07T16:47:03Z] Running step azure-aks-hypershift-ephemeral-creds-guest-f7-destroy. 
INFO[2025-01-07T17:03:42Z] Step azure-aks-hypershift-ephemeral-creds-guest-f7-destroy succeeded after 16m38s. 
INFO[2025-01-07T17:03:42Z] Running step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-role-assignment. 
INFO[2025-01-07T17:03:59Z] Step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-role-assignment succeeded after 17s. 
INFO[2025-01-07T17:03:59Z] Running step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-sp-and-custom-role. 
INFO[2025-01-07T17:04:24Z] Step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-sp-and-custom-role succeeded after 25s. 
INFO[2025-01-07T17:04:24Z] Running step azure-aks-hypershift-ephemeral-creds-guest-f7-aks-deprovision. 
INFO[2025-01-07T17:09:21Z] Step azure-aks-hypershift-ephemeral-creds-guest-f7-aks-deprovision succeeded after 4m56s. 
INFO[2025-01-07T17:09:21Z] Running step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-resourcegroup. 
INFO[2025-01-07T17:13:29Z] Step azure-aks-hypershift-ephemeral-creds-guest-f7-azure-deprovision-resourcegroup succeeded after 4m8s.

@heliubj18
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@heliubj18: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 8, 2025
@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heliubj18, LiangquanLi930

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@heliubj18: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/e2e-azure-aks-ovn-conformance aaad179 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-ephemeral-creds-guest-f7 aaad179 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-azure-aks-hypershift-ephemeral-creds-guest-f7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5898962 into openshift:master Jan 8, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants