Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-1552: Add assembly content for 'Accessing metrics' section #86759

Merged

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Jan 7, 2025

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
The changes it this PR are not yet user-facing.
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for a separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Link to docs preview:

QE review: not needed, just moving the existing content

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Link to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving the content around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for the separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eromanova97 eromanova97 force-pushed the OBSDOCS-1552 branch 2 times, most recently from ee17759 to 4f72f1b Compare January 7, 2025 13:06
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Link to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving the content around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for the separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving the content around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for the separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@@ -33,7 +33,7 @@ include::modules/monitoring-querying-metrics-by-using-the-federation-endpoint-fo
include::modules/accessing-metrics-outside-cluster.adoc[leveloffset=+1]

// Resources reference for accessing API endpoints
include::modules/monitoring-resources-reference-for-the-cluster-monitoring-operator.adoc[leveloffset=+1]
//include::modules/monitoring-resources-reference-for-the-cluster-monitoring-operator.adoc[leveloffset=+1]
Copy link
Contributor Author

@eromanova97 eromanova97 Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module is commented out in the old assembly due to the module not having the "context" part in its ID, which was breaking the build. This cannot be currently changed for the scope of this PR, because the module is automatically generated and needs changes in another repository first. This will not cause any issues though and can be done later, as this old assembly will be eventually deleted before publishing.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving the content around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for the separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for the separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for a separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
The changes it this PR are not yet user-facing.
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for a separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@@ -6,7 +6,41 @@ include::_attributes/common-attributes.adoc[]

toc::[]

TBD
Copy link
Contributor Author

@eromanova97 eromanova97 Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the clarification due to the GitHub render here: The content here is just copy-pasted from the observability/monitoring/accessing-third-party-monitoring-apis.adoc assembly file. No changes added. This PR only moves things around.

(The only difference is not including the xrefs yet)

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 7, 2025
@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 7, 2025
@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue.

In response to this:

Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure

Issue: OBSDOCS-1552

Links to docs preview:

QE review: not needed, just moving the existing content

Additional information:
The changes it this PR are not yet user-facing.
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.

Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.

NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for a separate PR.

Let me know if you have any additional questions, thank you!

The following are the sections that need review (you can find it under Observability -> Monitoring) :
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 8, 2025

@eromanova97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 8, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 8, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 8, 2025
@xenolinux xenolinux merged commit c7718a7 into openshift:monitoring-docs-restructure Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants