-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1552: Add assembly content for 'Accessing metrics' section #86759
OBSDOCS-1552: Add assembly content for 'Accessing metrics' section #86759
Conversation
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ee17759
to
4f72f1b
Compare
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -33,7 +33,7 @@ include::modules/monitoring-querying-metrics-by-using-the-federation-endpoint-fo | |||
include::modules/accessing-metrics-outside-cluster.adoc[leveloffset=+1] | |||
|
|||
// Resources reference for accessing API endpoints | |||
include::modules/monitoring-resources-reference-for-the-cluster-monitoring-operator.adoc[leveloffset=+1] | |||
//include::modules/monitoring-resources-reference-for-the-cluster-monitoring-operator.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module is commented out in the old assembly due to the module not having the "context" part in its ID, which was breaking the build. This cannot be currently changed for the scope of this PR, because the module is automatically generated and needs changes in another repository first. This will not cause any issues though and can be done later, as this old assembly will be eventually deleted before publishing.
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -6,7 +6,41 @@ include::_attributes/common-attributes.adoc[] | |||
|
|||
toc::[] | |||
|
|||
TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the clarification due to the GitHub render here: The content here is just copy-pasted from the observability/monitoring/accessing-third-party-monitoring-apis.adoc
assembly file. No changes added. This PR only moves things around.
(The only difference is not including the xrefs yet)
/label peer-review-needed |
observability/monitoring/accessing-metrics/accessing-metrics-as-a-developer.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-metrics-as-a-developer.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-metrics-as-an-administrator.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-metrics-as-an-administrator.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-monitoring-apis-by-using-the-CLI.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-monitoring-apis-by-using-the-CLI.adoc
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-monitoring-apis-by-using-the-CLI.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-monitoring-apis-by-using-the-CLI.adoc
Outdated
Show resolved
Hide resolved
observability/monitoring/accessing-metrics/accessing-monitoring-apis-by-using-the-CLI.adoc
Outdated
Show resolved
Hide resolved
@eromanova97: This pull request references OBSDOCS-1552 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4f72f1b
to
dff3235
Compare
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7718a7
into
openshift:monitoring-docs-restructure
Version(s): `none for cherry-picking, only merge to monitoring-docs-restructure
Issue: OBSDOCS-1552
Links to docs preview:
QE review: not needed, just moving the existing content
Additional information:
The changes it this PR are not yet user-facing.
This PR moves content from old to the new assemblies. The content in the original assembly is still there . The reason is to not lose any content while moving it around. There will be a separate issue that will make sure that all the content is transfered as needed.
Therefore, the main thing to check in this PR is to see if the structure in the linked chapters looks good and renders without issues.
NOTE: The links and xrefs will be filled in in a different PR, because the content from other assemblies still needs to be moved to the new place, which means that if I filled the links now, I would have to keep repairing them later. So I am keeping that for a separate PR.
Let me know if you have any additional questions, thank you!
The following are the sections that need review (you can find it under Observability -> Monitoring) :