Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS-1828: Clarify supported format for osImages.openshiftVersion in ZTP docs #86715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TELCODOCS-1828: Clarify supported format for osImages.openshiftVersion in ZTP docs #86715

wants to merge 1 commit into from

Conversation

amolnar-rh
Copy link
Contributor

@amolnar-rh amolnar-rh commented Jan 6, 2025 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/TELCODOCS-1828

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 6, 2025
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 6, 2025 •
edited
Loading

🤖 Mon Jan 06 16:48:40 - Prow CI generated the docs preview:

https://86715--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/ztp-preparing-the-hub-cluster.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/TELCODOCS-1828

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielerez
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@amolnar-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 6, 2025
@mburke5678
Copy link
Contributor

@amolnar-rh One comment. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 6, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1828 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.14, 4.15, 4.16, 4.17, 4.18

Issue: https://issues.redhat.com/browse/TELCODOCS-1828

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amolnar-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 6, 2025
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 6, 2025
@mburke5678
Copy link
Contributor

@amolnar-rh Did you get QE sign-off?

@amolnar-rh amolnar-rh changed the title TELCODOCS-1828:Clarify supported format for osImages.openshiftVersion in ZTP docs TELCODOCS-1828: Clarify supported format for osImages.openshiftVersion in ZTP docs Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburke5678 mburke5678 mburke5678 left review comments

@danielerez danielerez danielerez left review comments

Assignees

@danielerez danielerez

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amolnar-rh @openshift-ci-robot @ocpdocs-previewbot @danielerez @mburke5678