Set empty TARGETVARIANT and BUILDVARIANT

[Honny1]

This PR sets empty values as the default value for the TARGETVARIANT and BUILDVARIANT buildin arguments since Docker does not insert these values for ARM64.

Related PR:

• Fix Conformance tests on ARM64 containers/buildah#5990

[openshift-ci]

Hi @Honny1. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nalind]

/ok-to-test

[nalind]

I'm seeing errors from unit tests in the main directory when I run them in my arm64-on-amd64 VM with these changes. Are you getting passing results when running go test ./... at the top level?

[Honny1]

I also failed unit tests. (Including master) I checked the failed tests and they expect that a variant should be set. I think the tests are wrong. WDYT?

[nalind]

Yes, if they expected behavior which we now consider to be incorrect, they need to be updated to expect what we consider to be correct.

[openshift-ci]

@Honny1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Honny1]

I adjusted the tests to expect the correct values.

[nalind]

/lgtm
Thanks!

[nalind]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nalind]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment