Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating jenkinsfile with using update-alternatives to switch JDK version #4333

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

jordarlu
Copy link
Contributor

Description

Updating jenkinsfile with using update-alternatives to switch JDK version per the parameter in manifest

Issues Resolved

#4272

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6eb6f8b) 91.34% compared to head (485a065) 91.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4333   +/-   ##
=======================================
  Coverage   91.34%   91.35%           
=======================================
  Files         189      190    +1     
  Lines        6169     6175    +6     
=======================================
+ Hits         5635     5641    +6     
  Misses        534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jeff Lu <[email protected]>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add assertion to the test file confirming this behavior? https://github.com/opensearch-project/opensearch-build/blob/main/tests/jenkins/TestPublishMinSnapshots.groovy

Thanks!

@jordarlu
Copy link
Contributor Author

Can you please add assertion to the test file confirming this behavior? https://github.com/opensearch-project/opensearch-build/blob/main/tests/jenkins/TestPublishMinSnapshots.groovy

Thanks!

Thanks for the comment, @gaiksaya. I just added an assertion to validate there will be a JDK set up by using the update-alternatives accordongly.

@gaiksaya gaiksaya merged commit 4b0b53d into opensearch-project:main Jan 10, 2024
13 checks passed
@jordarlu jordarlu deleted the min_snapshot_jenkins_jdk branch January 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants