-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating jenkinsfile with using update-alternatives to switch JDK version #4333
Updating jenkinsfile with using update-alternatives to switch JDK version #4333
Conversation
Signed-off-by: Jeff Lu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4333 +/- ##
=======================================
Coverage 91.34% 91.35%
=======================================
Files 189 190 +1
Lines 6169 6175 +6
=======================================
+ Hits 5635 5641 +6
Misses 534 534 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jeff Lu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add assertion to the test file confirming this behavior? https://github.com/opensearch-project/opensearch-build/blob/main/tests/jenkins/TestPublishMinSnapshots.groovy
Thanks!
Signed-off-by: Jeff Lu <[email protected]>
Thanks for the comment, @gaiksaya. I just added an assertion to validate there will be a JDK set up by using the update-alternatives accordongly. |
Signed-off-by: Jeff Lu <[email protected]>
Description
Updating jenkinsfile with using update-alternatives to switch JDK version per the parameter in manifest
Issues Resolved
#4272
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.