Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard field use only 3-gram to index #17349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HUSTERGS
Copy link
Contributor

Description

Accorrding the test result of #17099 , change wildcard field to only index 3-gram of the input data, instead of 1-3 gram, to reduce the overall index size caused by long positing list of single and double charaters, which is not really helpful when search. And also help to increase the write speed.

Related Issues

Resolves #17099

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 3abbea7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msfroh Is this worth creating a rolling upgrade test case for to ensure compatibility across the versions?

@HUSTERGS Can you rebase this with the latest from main? I think the bwc tests are failing due to a version bump.

CHANGELOG.md Outdated Show resolved Hide resolved
@HUSTERGS HUSTERGS force-pushed the feat/3gram_wildcard branch from 3abbea7 to b910b03 Compare February 14, 2025 02:26
Signed-off-by: gesong.samuel <[email protected]>
Signed-off-by: gesong.samuel <[email protected]>
@HUSTERGS HUSTERGS force-pushed the feat/3gram_wildcard branch from b910b03 to b3576d9 Compare February 14, 2025 02:27
Copy link
Contributor

❌ Gradle check result for b3576d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@HUSTERGS
Copy link
Contributor Author

Flaky tests: #17347

@msfroh
Copy link
Collaborator

msfroh commented Feb 14, 2025

Flaky tests: #17347

Oh, shoot! That one is my fault. I made it "less flaky" a couple of weeks ago, but apparently missed something.

Copy link
Contributor

✅ Gradle check result for b3576d9: SUCCESS

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (38e4b33) to head (b3576d9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/index/mapper/WildcardFieldMapper.java 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17349      +/-   ##
============================================
- Coverage     72.41%   72.32%   -0.09%     
+ Complexity    65569    65478      -91     
============================================
  Files          5291     5291              
  Lines        304338   304321      -17     
  Branches      44181    44179       -2     
============================================
- Hits         220376   220101     -275     
- Misses        65917    66186     +269     
+ Partials      18045    18034      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Wildcard field use only 3-gram to index
3 participants