[Tiered Caching] Remove PLUGGABLE_CACHE feature flag #17344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteralfonsi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
enhancement
Signed-off-by: Peter Alfonsi <[email protected]>
peteralfonsi
force-pushed
the
remove-tc-feature-flag
branch
from
f8ebfd4 to
cb6dea2
Compare
Signed-off-by: Peter Alfonsi <[email protected]>
|
❌ Gradle check result for efe585e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As tiered caching will no longer be experimental in 3.0, removes its feature flag. Now users can always specify a store name via setting, and cache implementations will always track their own stats as exposed in
GET _nodes/stats/caches/....Modifies some UTs to account for this. Manually tested with debugger that the TSC can be used in the IRC via setting with the new changes. Also manually checked the response in
GET _nodes/stats/caches/request_cacheis populated even for the default cache.Related Issues
Resolves #17343
Sub-issue of #17303
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.