Updating odh kserve kustomize manifests

[KillianGolds]

What this PR does / why we need it:

Updating deprecated kustomize labels.

Here is a gist of the differing outputs of kustomize build command has comparing original deprecated syntax and updated syntax: https://gist.github.com/KillianGolds/ef98951981f04ce5f95dbca514a328ea

With the old syntax storageInitializer resolves as such:

storageInitializer: |-
    {
        "image" : "quay.io/opendatahub/kserve-storage-initializer:latest",
        "memoryRequest": "100Mi",
        "memoryLimit": "1Gi",
        "cpuRequest": "100m",
        "cpuLimit": "1",
        "enableDirectPvcVolumeMount": true
    }

New syntax is overwriting the json and just placing the image:

storageInitializer: quay.io/opendatahub/kserve-storage-initializer:latest

The same is happening for router, logger, agent and batcher.

I believe this is due to Kustomize v5 lack of handling of JSON.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

• Test A

• Test B

• Logs

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

• Have you added unit/e2e tests that prove your fix is effective or that this feature works?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

Release note:

Re-running failed tests

• /rerun-all - rerun all failed workflows.
• /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KillianGolds
Once this PR has been reviewed and has the lgtm label, please assign heyselbi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[VedantMahabaleshwarkar]

maybe this should be data.kserve-storage-initializer.image or data.kserve-storage-initializer["image"] (not sure how kustomize treats nesting in json the same as yaml or not)
If it works it should be the same solution for the rest as well

[KillianGolds]

Tried this, unfortunately .image results in an error:

Error: error looking up replacement source: wrong node kind: expected MappingNode but got ScalarNode: node contents:
quay.io/opendatahub/kserve-storage-initializer:latest

and ["image"] results in:

Error: fieldPath data.kserve-storage-initializer["image"] is missing for replacement source ConfigMap.[noVer].[noGrp]/kserve-parameters.[noNs]