Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple workqueue from TCME #374

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+67 −73
Open

feat: decouple workqueue from TCME #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14eb84a
feat: workqueue wip
jamil314 Jan 21, 2025
6db414f
Merge branch 'develop' into events-v2-workqueue
jamil314 Jan 22, 2025
5ff1d5e
fix: use same format for intl as in summarypage
jamil314 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 60 additions & 63 deletions src/form/tennis-club-membership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,75 +257,72 @@
workqueues: [
{
id: 'all',
title: {
defaultMessage: 'All events',
description: 'Label for in progress workqueue',
id: 'event.tennis-club-membership.workqueue.all.label'
},
fields: [
{
id: 'applicant.firstname'
},
{
id: 'applicant.surname'
column: 'title',

Check failure on line 262 in src/form/tennis-club-membership.ts

View workflow job for this annotation

GitHub Actions / test 

Type '{ column: string; label: { defaultMessage: string; description: string; id: string; }; }' is not assignable to type '{ id: string; label?: { id: string; defaultMessage: string; description: string; } | undefined; }'.
label: {
defaultMessage: '{applicant.firstname} {applicant.surname}',
description: 'Label for name in all workqueue',
id: 'event.tennis-club-membership.workqueue.all.name.label'
}
}
],
filters: []
},
{
id: 'ready-for-review',
title: {
defaultMessage: 'Ready for review',
description: 'Label for in review workqueue',
id: 'event.tennis-club-membership.workqueue.in-review.label'
},
fields: [
{
id: 'applicant.firstname'
},
{
id: 'event.type'
},
{
id: 'event.createdAt'
},
{
id: 'event.modifiedAt'
}
],
filters: [
{
status: ['DECLARED']
}
]
},
{
id: 'registered',
title: {
defaultMessage: 'Ready to print',
description: 'Label for registered workqueue',
id: 'event.tennis-club-membership.workqueue.registered.label'
},
fields: [
{
id: 'applicant.firstname'
},
{
id: 'event.type'
},
{
id: 'event.createdAt'
},
{
id: 'event.modifiedAt'
}
],
filters: [
{
status: ['REGISTERED']
}
]
}
// {
// id: 'ready-for-review',
// title: {
// defaultMessage: 'Ready for review',
// description: 'Label for in review workqueue',
// id: 'event.tennis-club-membership.workqueue.in-review.label'
// },
// fields: [
// {
// id: 'applicant.firstname'
// },
// {
// id: 'event.type'
// },
// {
// id: 'event.createdAt'
// },
// {
// id: 'event.modifiedAt'
// }
// ],
// filters: [
// {
// status: ['DECLARED']
// }
// ]
// },
// {
// id: 'registered',
// title: {
// defaultMessage: 'Ready to print',
// description: 'Label for registered workqueue',
// id: 'event.tennis-club-membership.workqueue.registered.label'
// },
// fields: [
// {
// id: 'applicant.firstname'
// },
// {
// id: 'event.type'
// },
// {
// id: 'event.createdAt'
// },
// {
// id: 'event.modifiedAt'
// }
// ],
// filters: [
// {
// status: ['REGISTERED']
// }
// ]
// }
],
deduplication: [
{
Expand Down
17 changes: 7 additions & 10 deletions src/form/v2/birth/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
title: {
id: 'event.birth.summary.title',
label: {
defaultMessage: '{applicant.firstname} {applicant.surname}',
defaultMessage: '{child.firstname} {child.surname}',
description: 'This is the title of the summary',
id: 'event.birth.summary.title'
}
Expand All @@ -38,17 +38,14 @@
workqueues: [
{
id: 'all',
title: {
defaultMessage: 'All birth events',
description: 'Label for all birth events workqueue',
id: 'event.birth.workqueue.all.label'
},
fields: [
{
id: 'child.firstname'
},
{
id: 'child.surname'
column: 'title',

Check failure on line 43 in src/form/v2/birth/index.ts

View workflow job for this annotation

GitHub Actions / test 

Type '{ column: string; label: { defaultMessage: string; description: string; id: string; }; }' is not assignable to type '{ id: string; label?: { id: string; defaultMessage: string; description: string; } | undefined; }'.
label: {
defaultMessage: '{child.surname} {child.firstname}',
description: 'Label for name in all workqueue',
id: 'event.birth.workqueue.all.name.label'
}
}
],
filters: []
Expand Down
Loading