Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seperate openshift block to handle openshift related configurations #245

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mittal-ishaan
Copy link
Contributor

No description provided.

@mittal-ishaan mittal-ishaan marked this pull request as ready for review December 26, 2024 22:13
@kastl-ars
Copy link
Contributor

Any news on this one? This looks promising...

@toscott
Copy link
Collaborator

toscott commented Jan 20, 2025

Hi @mittal-ishaan. Is there a conversation or specific problem this is trying to solve? It looks like it is several backwards incompatible changes and doesn't provide any functionality that can't already be achieved using the existing:
opencost.ui.extraVolumeMounts

Appears like its an attempt to maybe simplify configuration for openshift clusters?

@mittal-ishaan
Copy link
Contributor Author

Hi @toscott,

The primary goal here is to simplify the installation process for OpenCost in OpenShift environments. Currently, setting up OpenCost in OpenShift is challenging, as users need to sift through various issues and discussions to find the necessary volume mounts, as detailed in this issue. By including these configurations directly in the Helm chart, I hope to make the installation process more straightforward for OpenShift users. Additionally, I want to centralize and gate other OpenShift-specific configurations.

What are your thoughts?

@toscott
Copy link
Collaborator

toscott commented Feb 3, 2025

Hi @toscott,

The primary goal here is to simplify the installation process for OpenCost in OpenShift environments. Currently, setting up OpenCost in OpenShift is challenging, as users need to sift through various issues and discussions to find the necessary volume mounts, as detailed in this issue. By including these configurations directly in the Helm chart, I hope to make the installation process more straightforward for OpenShift users. Additionally, I want to centralize and gate other OpenShift-specific configurations.

What are your thoughts?

Sorry for the delay.

I like the idea of simplifying configuration for new users. It does make me a little nervous to break backward compatibility though.
With your current changes, I would recommend a major version bump for the chart so anyone who has auto minor/patch version updates enabled doesn't get surprised with something breaking.

What do you think about bumping the chart to 2.0.0 and calling it good? Also glad to see you were added as a contributor! Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants