Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Expense form): Update form inputs to use new inputs & improve error state #10909

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gustavlrsn
Copy link
Member

@gustavlrsn gustavlrsn commented Jan 16, 2025

Resolves opencollective/opencollective#7751 and opencollective/opencollective#7750

Description

  • Updates form inputs to use new shadcn/ui inputs
  • Improve error state of those inputs to show a bold error border
  • Remove step error state, this is instead handled by the sub-fields in the section
  • Scroll to first errored step/section after submit

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 3:22pm
opencollective-styleguide ❌ Failed (Inspect) Jan 22, 2025 3:22pm

@gustavlrsn gustavlrsn force-pushed the fix/expense-form-inputs branch from c469673 to c2ac1c1 Compare January 22, 2025 15:06
@gustavlrsn gustavlrsn marked this pull request as ready for review January 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation: "date required" is not surfaced in the UI
1 participant